Differential D10261

Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.
ClosedPublic
Actions

Authored by markg on Feb 3 2018, 1:30 AM.

Details

Reviewers
dfaure
jtamate
Commits
R241:32b3bbcd16fd: Use the KFileItemListProperties copy constructor instead of the conversion from…
Summary

As the title says. Minor optimization.

Test Plan

Ran the testcases, all pass just fine.
Also in callgrind it's one less call to the KFileItemListProperties constructor that takes a KFileItemList. A small win :)

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
markg created this revision.Feb 3 2018, 1:30 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 3 2018, 1:30 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
markg requested review of this revision.Feb 3 2018, 1:30 AM
jtamate accepted this revision.Feb 3 2018, 12:07 PM
This revision is now accepted and ready to land.Feb 3 2018, 12:07 PM
Closed by commit R241:32b3bbcd16fd: Use the KFileItemListProperties copy constructor instead of the conversion from… (authored by markg). · Explain WhyFeb 3 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/dropjob.cpp (2 lines)

Diff 26428

View Options

src/widgets/dropjob.cpp

Loading...