18e4d245d3 didn't quite have the right logic after all
Details
Details
Unittest passes (but this commit proves that it doesn't cover all cases...)
Diff Detail
Diff Detail
- Repository
- R244 KCoreAddons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks OK to me.
Had to read up on the KDE urls and local urls first though :)
Funny side note. Those that text/uri-list can contain comments! https://tools.ietf.org/html/rfc2483#section-5
But judging from the qmimedata.cpp file, Qt also doesn't check for that (or i didn't find it, possible as well).
| src/lib/io/kurlmimedata.cpp | ||
|---|---|---|
| 67 | future cleanup: remove all the QString::fromLatin1(s_...) in this file with a call to QString kdeUriListMime() { return QStringLiteral("..."); } | |
| src/lib/io/kurlmimedata.cpp | ||
|---|---|---|
| 67 | ||