Small performance improvement of just not caching the targetUrlList() result.
The only use for that list was returning it in KFileItemListProperties::urlList() so we might as well just call m_items.targetUrlList() there and not save it locally.
This came up as redundant list creation when figuring out where all the QUrl objects came from in a drag/drop action in Dolphin.
I did not benchmark this, seems rather trivial.
Ran the testcases (most relevant is probably KFileItemTest), all pass just fine.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
If urlList() is called often, then this is actually slower (targetUrlList() has to iterate and convert). But yeah I doubt it is called often...