Fix dupe handling in requestAddLauncherToActivities; improve unit test
ClosedPublic

Authored by hein on Feb 2 2018, 7:34 PM.

Details

Summary

The business logic was using the resolved URL in lookups in
internal data structures, instead of the internal key it
previously established equivalence to. This could lead to
junk in internal maps and unnecessarily emitted model changes.

This also improves the unit test not to require apps to be
installed, fixing the CI failure over missing Dolphin.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Feb 2 2018, 7:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 2 2018, 7:34 PM
hein requested review of this revision.Feb 2 2018, 7:34 PM
kossebau resigned from this revision.Feb 5 2018, 2:28 PM

Tried few times to grasp all the related code to give this some insightful review, but always ran out of time. Sadly not qualitfied to review this code in reasonable amount of time.
At least triggered some general quality fixes of mine, so not all time lost :)

mart accepted this revision.Feb 6 2018, 10:08 AM
mart added a subscriber: mart.

for after 5.12.0 but good for backport

This revision is now accepted and ready to land.Feb 6 2018, 10:08 AM
This revision was automatically updated to reflect the committed changes.