Differential D10247

Add a width ratio to the OverlaySheet
AbandonedPublic
Actions

Authored by icota on Feb 2 2018, 9:59 AM.

Details

Reviewers
None
Group Reviewers
Kirigami
Summary

Instead of hardcoding the OverlaySheet to half the mainItem width multiply by the ratio to enable wider or skinnier sheets

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
icota created this revision.Feb 2 2018, 9:59 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 2 2018, 9:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
icota requested review of this revision.Feb 2 2018, 9:59 AM
mart added a subscriber: mart.Feb 2 2018, 3:19 PM

hmm I don't think this is the right approach to it.. it should rather use size hints from the sheet contents (which if you want can also be a ratio of whatever the parent, but that would be user-specific)

icota abandoned this revision.Feb 2 2018, 3:41 PM

Revision Contents
Changeset List

Diff 26369

View Options

src/controls/templates/OverlaySheet.qml

Loading...