[server] Add support for the frame semantics of Pointer version 5
ClosedPublic

Authored by graesslin on Feb 1 2018, 4:51 PM.

Details

Summary

This change implements the required changes for wl_seat version 5.
There seem to be applications which require version 5 and refuse to
start if the server doesn't provide it. Thus we need to provide it.

The main difference with version 5 is that pointer need to send a
frame event after each logical group of events. As we don't support the
new events from version 5 yet, we just emit the frame after each event
and implement the suggested semantics for the enter/leave behavior.

To really make use of this, we will have to implement additions in the
API and then in KWin to expose the new API elements. But to just support
the semantics we don't need it.

BUG: 389189

Test Plan

Extended autotest

Diff Detail

Repository
R127 KWayland
Branch
server-pointer-frame-semantics
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Feb 1 2018, 4:51 PM
Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptFeb 1 2018, 4:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 1 2018, 4:51 PM
Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 1 2018, 4:51 PM
Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptFeb 21 2018, 5:10 PM

Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after each event compositors are not able to group these.

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 24 2018, 9:58 PM

Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after each event compositors are not able to group these.

Yes and no. For all the events we currently support, there is no grouping. For new event types, which we do not yet support, we need to add API to allow the compositer to send the frame.

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptFeb 25 2018, 8:00 AM
romangg accepted this revision.Feb 25 2018, 9:21 AM
This revision is now accepted and ready to land.Feb 25 2018, 9:21 AM
Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 25 2018, 9:21 AM
romangg edited projects, added Plasma on Wayland; removed Plasma.Feb 25 2018, 9:22 AM
Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 25 2018, 9:22 AM
Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptFeb 25 2018, 9:27 AM
bcooksley edited projects, added Plasma; removed Plasma on Wayland.Feb 26 2018, 8:55 AM
Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptFeb 26 2018, 8:55 AM
This revision was automatically updated to reflect the committed changes.