Same as title.
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R241:ecaf513ed3cd: [KIO] Remove PrivilegeExecution job flag
Unfortunately, it seems no one beside me (and few others?) has tested privilege execution feature yet.
In this situation it's unclear which flag is more suitable. So I am removing PrivilegeExecution flag
based on the tests I have done on my local setup and little bit of instinct.
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for remembering to clean this up in time.
Indeed not many people tested it, since it's still disabled...
I tried to revert 5a1ea84476, restart kdeinit5 and kill kio_file instances, and copying a file to '/' indeed offers to do it as root, but then fails (no password prompt is shown). Either it's broken or I'm not testing it right (I'm installing everything into a custom prefix, so I copied the polkit file to /usr/share/polkit-1/actions/org.kde.kio.file.policy but maybe there are other files I need to copy?)
Comment Actions
Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It worked for me.
On a completely different note, do all jobs have a uidelgate or does passing HideProgressInfo flag prevent it from being created?
Comment Actions
Ah, systemd stuff, not dbus stuff (which finds files in my custom prefix). Thanks, that worked, I was able to copy a file to '/'.
The context menu for that file crashes kded5 (kdesvnd), I'm debugging that now...
On a completely different note, do all jobs have a uidelgate or does passing HideProgressInfo flag prevent it from being created?
Neither ;)
Some jobs don't have a uidelegate, those where we call setUiDelegate(0) (as is often done in unittests, to prevent any interaction with the user, like "file exists, do you want to overwrite or skip").
HideProgressInfo doesn't remove such interaction, so the delegate still exists when setting HideProgressInfo.