Differential D10224

Give a default player name
AbandonedPublic
Actions

Authored by nicolasfella on Feb 1 2018, 12:13 PM.

Details

Reviewers
broulik
apol
Summary

Default to "Plasma Browser Integration" as a default MPRIS player identity. This makes KDE Connect look prettier.

Test Plan

Before:

After:

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
nicolasfella requested review of this revision.Feb 1 2018, 12:13 PM
nicolasfella created this revision.
apol added a subscriber: apol.Feb 1 2018, 12:25 PM

Is this a workaround because Plasma Browser Integration doesn't provide an identity? Because if so I'd say the PBI should be fixed.

Here if anything it should add "Default" or "Unknown".

apol requested changes to this revision.Feb 1 2018, 12:25 PM
This revision now requires changes to proceed.Feb 1 2018, 12:25 PM
nicolasfella added a comment.Feb 2 2018, 12:27 AM

Well, I am trying to fix PBI. The problem is that my Firefox (58.0.1) does not get recognized as such. Chrome works fine. I will try to dig into the underlying issue.

nicolasfella abandoned this revision.Feb 3 2018, 5:49 PM

Turns out i wasn't running the latest extension. Works fine now.

Revision Contents
Changeset List

PathPackages
Mhost/mprisplugin.cpp (2 lines)

Diff 26309

View Options

host/mprisplugin.cpp

Loading...