| hein |
| Plasma |
While I really like the list view for the popup, I also have a "Screenshots" folderview and there I prefer to have huge icons to see everything at a glance. This allows to choose between the default list view and the icon view mode with cascading popups identical to what you get on the desktop.
BUG: 359618
FIXED-IN: 5.6.0
It works nicely. Switching between view modes at runtime is broken, though, ie. the dialog doesn't update its size and also the delegates that were already there aren't updated until I scroll them out of view and back.
| Lint Skipped |
| Unit Tests Skipped |
Uh that doesn't sound like "it works nicely" ... I'll review a more complete revision later? ;)
Oh and: We recently got a user feature request to allow configuring the icon size in popup mode, it probably makes sense to do this as part of this change if you want to. Note that list mode and the current icon size should IMHO be the defaults.
This review is all about that Bug 359618.
I don't change the list view, it's just that if you don't like the list view in the popup (which is still the default) you can choose icon mode and there you can also choose the icon size.
Did you look into why the invalidate hack is necessary? Why don't the delegates adjust properly?
So basically to get this moving along I'd like investigation of why those delegates don't fix themselves -- let's see if we can't avoid adding a new FIXME?
Using States {} I can achieve atomic anchor changes; it seems when you use regular bindings and you have horizontal/verticalCenter and a left/right/top/bottom anchor and you try to swap them, it might break or be ignored depending on the order of evaluation because how dare you have more than one anchor for one axis.
I wanted to make one huge State {} at the top but I got frequent crashes with it deep down in QQuickAnchor setTop when starting a drag operation; this does not happen with the two smaller ones.