Calendar, fixed calendar dimensions for vertical screens
ClosedPublic

Authored by asagtani on Jan 31 2018, 8:42 PM.

Details

Summary

Earlier in portrait mode, calendar dimensions were too small and it was hard to play the activity.

Repositioned score from the right of the calendar to the bottom of the calendar to create extra space on right and increased width of the calendar. Now, the calendar can be easily accessed on vertical screens too.

Sample -->
Horizontal Mode
https://cdn.pbrd.co/images/H5woPRM.png
https://cdn.pbrd.co/images/H5wp7p5.png

Vertical Mode
https://cdn.pbrd.co/images/H5wpkDB.png
https://cdn.pbrd.co/images/H5wpFwq.png

Looks fine in both Calendar and Find the Day activity.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
asagtani created this revision.Jan 31 2018, 8:42 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 31 2018, 8:42 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
asagtani updated this revision to Diff 26425.Feb 3 2018, 11:32 AM

vertical mode -->
https://cdn.pbrd.co/images/H5V3KQj.png
https://cdn.pbrd.co/images/H5V5Hq3.png

Horizontal mode -->
https://cdn.pbrd.co/images/H5V60mr.png
https://cdn.pbrd.co/images/H5V6hpW.png

  1. Shifted score and ok button at bottom of calendar for both vertical and horizontal mode
  2. Increased width and height of calendar
  3. Decreased height of month navigation bar of the calendar for the horizontal mode.
jjazeix added inline comments.
src/activities/calendar/Calendar.qml
383

it should always be a circle and have same height/width

asagtani updated this revision to Diff 26478.Feb 4 2018, 6:24 AM

fixed ok button dimensions

jjazeix accepted this revision.Feb 16 2018, 7:17 PM
This revision is now accepted and ready to land.Feb 16 2018, 7:17 PM
jjazeix closed this revision.Feb 16 2018, 7:18 PM

commited in https://commits.kde.org/gcompris/2fa566006d1242b34f52029b3a431bd2e9a8afcd with a small change for days column anchoring