implement a trackdata helper to display more detailed track information
ClosedPublic

Authored by astippich on Jan 31 2018, 5:35 PM.

Details

Summary

display all the information we currently have about the file.
may also enable some cleanup for mediaplaylist roles.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jan 31 2018, 5:35 PM
astippich created this revision.
astippich added a project: Elisa.

Screenshot:

I don't know if this is the best approach in the end, but it enables the display of all the information we have without passing each explicitly in the models

astippich updated this revision to Diff 26434.Feb 3 2018, 1:21 PM
  • Merge branch 'master' into trackdatahelper
  • update data and fix bugs

gentle ping :)

I am not so sure about the approach given that the list of possible metadata is fixed by the c++ code.
At the same time given that Elisa is build on top of KFileMetaData right now, this should not be too much a problem given KFileMetaData has the same limitation.
I need to test and hope to be able to do it tomorrow. So far, I am OK with this change.

mgallien requested changes to this revision.Feb 10 2018, 2:28 PM

Nice work. Can you fix the comment and after that we should be good to go ?

src/trackdatahelper.h
145–175

Clazy is complaining that they do not look like slots given that they are const and return a value.
If you need to call them from qml, you can use Q_INVOKABLE.
Can you modify them to do that ?

This revision now requires changes to proceed.Feb 10 2018, 2:28 PM
astippich updated this revision to Diff 27087.Feb 13 2018, 6:11 PM
  • Merge branch 'master' into trackdatahelper
  • convert slots to invokables
astippich updated this revision to Diff 27917.Feb 24 2018, 2:35 PM
  • Merge branch 'master' into trackdatahelper
mgallien accepted this revision.Feb 25 2018, 3:06 PM

Sorry for the delay. Thanks for your work.

This revision is now accepted and ready to land.Feb 25 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.