Use correct arrow cursor for Annotations' close buttons
ClosedPublic

Authored by dileepsankhla on Jan 31 2018, 5:15 PM.

Details

Summary

When hovering the mouse over the X symbol to close a note the cursor remains the same of the current shape (hand, selection cursor) based on the tool selected.
This patch morphe the cursor to the standard arrow over the X symbol to close a note by adding setCursor() call in the CloseButton constructor

BUG: 384381

Test Plan
  1. Open okular and select Tools -> Review or press F6 to create a new pop-up note
  2. Hover the mouse cursor over the close button (X) of the pop-up note window
  3. You will see the standard arrow instead of the current tool based cursor.

Screenshot below (the tooltip saying "Close this note" was not captured by Spectacle application)

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dileepsankhla created this revision.Jan 31 2018, 5:15 PM
Restricted Application added a project: Okular. · View Herald TranscriptJan 31 2018, 5:15 PM
Restricted Application added a subscriber: Okular. · View Herald Transcript
dileepsankhla requested review of this revision.Jan 31 2018, 5:15 PM
ngraham edited the summary of this revision. (Show Details)Jan 31 2018, 5:22 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working?

Also, the title of the revision is really better suited to being in the summary. For the title, try to briefly explain the overall purpose. Maybe something like "Use correct arrow cursor for Annotations' close buttons"

dileepsankhla retitled this revision from Added setCursor() call in the CloseButton constructor to Use correct arrow cursor for Annotations' close buttons.Jan 31 2018, 5:42 PM
dileepsankhla edited the summary of this revision. (Show Details)
dileepsankhla edited the test plan for this revision. (Show Details)

Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working?

Also, the title of the revision is really better suited to being in the summary. For the title, try to briefly explain the overall purpose. Maybe something like "Use correct arrow cursor for Annotations' close buttons"

Thank you so much. I have done that.

This comment was removed by dileepsankhla.
dileepsankhla edited the summary of this revision. (Show Details)Jan 31 2018, 5:50 PM

Actually, the BUG: line can't be a link, I'm afraid. It has to be just: "BUG: <number>" See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

ngraham accepted this revision.Jan 31 2018, 5:59 PM

Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this.

This revision is now accepted and ready to land.Jan 31 2018, 5:59 PM
dileepsankhla edited the summary of this revision. (Show Details)Jan 31 2018, 5:59 PM

Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this.

Thank you so much. Fixed it.

Thanks! One more thing. The commit message has the following for your name:

Author: RobStat <sankhla.dileep96@gmail.com>
Date: Wed Jan 31 10:54:37 2018 -0700

Would you mind using "Dileep Sankhla" instead of RobStat? for future patches? I'll correct it for this one.

This revision was automatically updated to reflect the committed changes.

Congratulations on your first patch! May it be the first of many more. If you're looking for inspiration, might I suggest checking out https://phabricator.kde.org/T6831?

Thank you so much. I'm checking it out.