DrKonqi: Enable DBus-Interface for debugging with KDevelop
ClosedPublic
Actions

Authored by croick on Jan 30 2018, 10:25 PM.

Details

Reviewers

Group Reviewers

KDevelop
Plasma: Workspaces

Commits

Summary

register a DBus service to make it work at all
service name unique by debuggee pid
switch hierarchy of adaptor and launcher
- a single adaptor keeps track of multiple launchers
- the debugger should provide a unique identification
only works with a corresponding patch in KDevelop

Test Plan

apply KDevelop patch D10196 and start a new KDevelop session "test"
enable the DrKonqi debug button
enable ptrace
start a kde program (kate for instance)
start "drkonqi --dialog --appname kate --pid xxxx"
check Debug options: gdb, KDevelop (GDB) - test, KDevelop (LLDB) - test
start another KDevelop session "test2" -> additional debug options are now available
end session "test2" -> additional options vanished again
select "KDevelop (GDB) - test" -> KDevelop raises, DrKonqi buttons are disabled
use the GDB console to detach the process and end GDB
DrKonqi buttons are reenabled again

Repository

R871 DrKonqi

Branch

kdevelopdbus

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

croick requested review of this revision.Jan 30 2018, 10:25 PM

minor style stuff, otherwise lgtm, esp. if it works now

src/README
5	could be a separate commit
src/debuggerlaunchers.cpp
42	could be a separate commit
src/debuggerlaunchers.h
81	here and below: style issues, afaik & and * should be next to the var name in frameworks code, like done in Qt

This revision is now accepted and ready to land.Mar 4 2018, 8:37 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/README (2 lines)
M			src/debuggerlaunchers.h (27 lines)
M			src/debuggerlaunchers.cpp (48 lines)
M			src/debuggermanager.h (2 lines)
M			src/debuggermanager.cpp (32 lines)