Differential D10194

Add social buttons to Kexi menu
ClosedPublic
Actions

Authored by piggz on Jan 30 2018, 7:57 PM.

Tags

Subscribers

None

Details

Reviewers

Maniphest Tasks

T7833: Add twitter and facebook icons to the KEXI menu

Commits

R71:a31f87c72a74: Add social buttons to Kexi menu

Summary

Add links to FB and Twitter to the Kexi menu

Test Plan

Click buttons, correct link opens

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

piggz created this revision.Jan 30 2018, 7:57 PM

Restricted Application added a project: KEXI. · View Herald TranscriptJan 30 2018, 7:57 PM

piggz requested review of this revision.Jan 30 2018, 7:57 PM

staniek accepted this revision.Jan 30 2018, 8:48 PM

staniek added inline comments.

src/main/KexiMainWindow_p.cpp
282	QLayout: Attempting to add QLayout "" to KexiMainMenu "", which already has a layout But I am doing the same error in line 241 so please land and I would fix the layout myself.
285	please fix double empty lines
308	please fix double empty lines

This revision is now accepted and ready to land.Jan 30 2018, 8:48 PM

piggz marked 2 inline comments as done.Jan 30 2018, 9:07 PM

Closed by commit R71:a31f87c72a74: Add social buttons to Kexi menu (authored by piggz). · Explain WhyJan 30 2018, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/main/KexiMainWindow_p.cpp (38 lines)

Diff 26226

src/main/KexiMainWindow_p.cpp

Loading...