Differential D10189

Let the terminal panel dock to any part of the window
ClosedPublic
Actions

Authored by ngraham on Jan 30 2018, 12:19 AM.

Details

Reviewers
None
Group Reviewers
Dolphin
Commits
R318:58f8b515b8ef: Let the terminal panel sit on the left or right side of the window
R318:108e10ca15be: Let the terminal panel dock to any part of the window
Summary

BUG: 362593

Just what it says: Let the terminal panel sit on the left or right side of the window.

Test Plan

Tested in KDE Neon:

  • Opened terminal panel, unlocked widgets, and tried to drag it to the right or left side of the window: I can
  • Put terminal panel on right side, quit Dolphin and opened Dolphin again: terminal panel appears on the right as expected
  • Put terminal panel on right side, closed terminal panel, quit Dolphin, opened Dolphin, and opened the terminal panel again: terminal panel appears on the right as expected
  • Removed dolphinrc file and opened terminal panel: appears on the bottom

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Jan 30 2018, 12:19 AM
ngraham created this revision.
ngraham edited the summary of this revision. (Show Details)Jan 30 2018, 12:19 AM
ngraham edited the test plan for this revision. (Show Details)
cfeck added a subscriber: cfeck.Jan 30 2018, 1:35 AM

Could you check where it appears when you have removed the Dolphin configuration files?

ngraham added a comment.Jan 30 2018, 1:45 AM

Ah yes, excellent idea. After doing that and restarting Dolphin, the terminal panel appears on the bottom like it's supposed to.

ngraham edited the test plan for this revision. (Show Details)Jan 30 2018, 1:47 AM
anthonyfieroni added a subscriber: anthonyfieroni.Jan 30 2018, 4:14 AM
anthonyfieroni added inline comments.
src/dolphinmainwindow.cpp
1293

It should be readed from rc. See where rc file is wtitten and add new section like TerminalDockArea

ngraham added inline comments.Jan 30 2018, 4:18 AM
src/dolphinmainwindow.cpp
1293

Is there a problem here that needs solving? With this patch, the terminal does remember its position across launches, even after you close it. This line just determines where it opens by default.

ngraham edited the test plan for this revision. (Show Details)Jan 30 2018, 4:20 AM
elvisangelaccio added a subscriber: elvisangelaccio.Jan 30 2018, 9:32 PM

Commit message should also say "top of the window".

Other than that, +1.

ngraham added a comment.Jan 30 2018, 9:35 PM
In D10189#198210, @elvisangelaccio wrote:

Commit message should also say "top of the window".

Other than that, +1.

That was actually already possible, but I'll update the message to be a bit more precise. Thanks!

ngraham retitled this revision from Let the terminal panel sit on the left or right side of the window to Let the terminal panel dock to any part of the window.Jan 30 2018, 9:36 PM
ngraham marked 2 inline comments as done.
This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2018, 12:06 AM
Closed by commit R318:108e10ca15be: Let the terminal panel dock to any part of the window (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.cpp (1 line)

Diff 26231

View Options

src/dolphinmainwindow.cpp

Loading...