Removed the "fastblur" path
ClosedPublic
Actions

Authored by anemeth on Jan 29 2018, 4:19 PM.

Details

Reviewers

graesslin
fredrik

Group Reviewers

KWin
Plasma
VDG

Commits

R108:f8ff40271e4d: Removed the "fastblur" path

Summary

Since the new blur is more efficient "fastblur" or "simpleblur" is not needed anymore for fullscreen blur.
Even my old low-end laptop from 2009 (with Intel T3300) can easily do fullscreen blur now with the new method without any hitch at all.

Diff Detail

Repository

R108 KWin

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

anemeth requested review of this revision.Jan 29 2018, 4:19 PM

anemeth created this revision.

anemeth edited the summary of this revision. (Show Details)Jan 29 2018, 4:23 PM

anemeth added reviewers: graesslin, KWin, Plasma.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 29 2018, 4:23 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham added a subscriber: ngraham.Jan 29 2018, 6:04 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 29 2018, 6:04 PM

fredrik added a subscriber: fredrik.Jan 31 2018, 6:57 PM

fredrik added inline comments.

effects/blur/blur.kcfg
10–11	This looks like an unrelated change.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 31 2018, 6:57 PM

Undone unrelated change

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 31 2018, 7:03 PM

anemeth marked an inline comment as done.Jan 31 2018, 7:03 PM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 31 2018, 7:03 PM

Code wise this LGTM.

Consider it accepted if the VDG has no objections.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 31 2018, 11:20 PM

ngraham added a reviewer: VDG.Jan 31 2018, 11:24 PM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 31 2018, 11:24 PM

No VDG objections!

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 31 2018, 11:24 PM

In D10181#198862, @fredrik wrote:

Code wise this LGTM.

Consider it accepted if the VDG has no objections.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 2 2018, 7:03 AM

fredrik accepted this revision.Feb 3 2018, 6:03 PM

This revision is now accepted and ready to land.Feb 3 2018, 6:03 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 3 2018, 6:03 PM

Closed by commit R108:f8ff40271e4d: Removed the "fastblur" path (authored by anemeth, committed by fredrik). · Explain WhyFeb 3 2018, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 3 2018, 6:05 PM

anemeth mentioned this in D9848: Updated the blur method to use the more efficient dual kawase blur algorithm..Mar 26 2018, 2:43 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptMar 26 2018, 2:43 PM

Revision Contents
Changeset List

		Path
M		effects/blur/blur.h (5 lines)
M		effects/blur/blur.cpp (51 lines)
M		effects/blur/blur.kcfg (3 lines)
M		effects/blur/blur_config.ui (10 lines)
D	M	effects/logout/data/1.10/logout-blur.frag (9 lines)
D	M	effects/logout/data/1.40/logout-blur.frag (14 lines)
M		effects/shaders.qrc (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26181	effe52f		Jan 29 2018, 4:19 PM	★	★
Diff 2	26279	effe52f	Undone unrelated change	Jan 31 2018, 7:03 PM	★	★
Diff 3	26452	dca8023	R108:f8ff40271e4d5e13646281244b5d259ee65b7669	Feb 3 2018, 6:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
02139431e15b	ca4bdfc185a7	828fa39fb66b	Alex Nemeth	Removed the "fastblur" path (Show More…)	Jan 29 2018, 4:19 PM
828fa39fb66b	ac5e5ffb19c1	effe52f65db6	Alex Nemeth	Updated blur default value from 5/15 to 10/15 (Show More…)	Jan 29 2018, 3:08 PM