Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked
ClosedPublic
Actions

Authored by graesslin on Jan 28 2018, 9:36 AM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:aefa11f11a25: Block geometry updates on move resize finish and don't configure xdg shell…

Summary

We send out too many configure requests when finishing move resize which
also triggers quick tiling. This change addresses the problem of the too
many configure requests by making the configure method check whether
geometry updates are blocked. And to make this work properly for the end
of finish move resize the complete method is wrapped in a geometry
update blocker.

Test Plan

Quick tiling test passes, both Wayland and X11 windows are
quick tiled correctly.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Jan 28 2018, 9:36 AM

Restricted Application added a project: KWin. · View Herald TranscriptJan 28 2018, 9:36 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin requested review of this revision.Jan 28 2018, 9:36 AM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 28 2018, 9:36 AM

graesslin mentioned this in D9980: Do not reset the size of window once we move it to an edge.Jan 28 2018, 9:36 AM

It's working and the patch looks good to me.

This revision is now accepted and ready to land.Jan 29 2018, 12:29 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 29 2018, 12:29 PM

ngraham added a subscriber: ngraham.Jan 30 2018, 2:05 AM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 30 2018, 2:05 AM

Closed by commit R108:aefa11f11a25: Block geometry updates on move resize finish and don't configure xdg shell… (authored by graesslin). · Explain WhyFeb 4 2018, 2:02 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 4 2018, 2:02 PM

We have to send a configure event when the resize is complete. So far it looks like this change tries to prevent that; when clientFinishUserMovedResized is emitted, geometry updates are still blocked and there is no RequestGeometryBlocker around.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/quick_tiling_test.cpp (4 lines)
M			geometry.cpp (1 line)
M			shell_client.h (2 lines)
M			shell_client.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26105	36e3632		Jan 28 2018, 9:36 AM	★	★
Diff 2	26503	e22d9d9	R108:aefa11f11a251d1270da08a73b367088baec0d56	Feb 4 2018, 1:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
1108fe1be683	fca28fb1c95a	36e36321014a	Martin Flöser	Block geometry updates on move resize finish and don't configure xdg shell… (Show More…)	Jan 28 2018, 9:33 AM