Correction with the & problem in tabs
ClosedPublic

Authored by carlavilla on Jan 27 2018, 9:35 PM.

Details

Summary

BUG: 382512

KSysGuard does not render the ampersand character in tab titles

Test Plan

Tested on Arch Linux with Plasma 5.11.5 and Qt 5.10

I added a tab with an & in the title and I checked that the & displays correctly.
I added a tab with two and more & and I checked that all the & displays correctly.
Also works when open a saved tab.

Diff Detail

Repository
R106 KSysguard
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
carlavilla created this revision.Jan 27 2018, 9:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 27 2018, 9:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
carlavilla requested review of this revision.Jan 27 2018, 9:35 PM
ngraham requested changes to this revision.Jan 28 2018, 2:32 AM
ngraham added a subscriber: ngraham.

Thanks for the patch! In general, it's best to title your Phabricator revision with a short description of the change or fix itself, and mention the bug in the Summary section. And when you do so, you'll want to put it in the form of "BUG: 382512" on its own line; this will cause that bugzilla ticket to automatically get closed if and when this lands. The Summary section should also receive a longer explanation of the change, if necessary. Also, please write something in the Test Plan section describing how you tested this change. Thanks again for the patch, and don't hesitate to ask if anything's unclear!

This revision now requires changes to proceed.Jan 28 2018, 2:32 AM

For patch it seems ok.
But Nathaniel is right. Describe how you tested it, add BUG: etc.

Otherwise it's a good start :)

Thanks.

carlavilla retitled this revision from Solved bug 382512 to Correction with the & problem in tabs.Feb 2 2018, 12:24 PM
carlavilla edited the summary of this revision. (Show Details)
carlavilla edited the test plan for this revision. (Show Details)

Sorry for my late response, but I've been moving all week.

ngraham resigned from this revision.Feb 2 2018, 2:04 PM
ngraham edited the summary of this revision. (Show Details)
ngraham accepted this revision.Feb 3 2018, 6:49 PM

Much better now, thanks! Works fine.

This revision is now accepted and ready to land.Feb 3 2018, 6:49 PM
This revision was automatically updated to reflect the committed changes.
fvogt reopened this revision.Feb 3 2018, 7:05 PM
fvogt added a subscriber: fvogt.

This needs to be commited to Plasma/5.12 as well, probably also Plasma/5.8.

This revision is now accepted and ready to land.Feb 3 2018, 7:05 PM

I'll cherry pick 'em.

This revision was automatically updated to reflect the committed changes.