BUG: 382512
KSysGuard does not render the ampersand character in tab titles
BUG: 382512
KSysGuard does not render the ampersand character in tab titles
Tested on Arch Linux with Plasma 5.11.5 and Qt 5.10
I added a tab with an & in the title and I checked that the & displays correctly.
I added a tab with two and more & and I checked that all the & displays correctly.
Also works when open a saved tab.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Thanks for the patch! In general, it's best to title your Phabricator revision with a short description of the change or fix itself, and mention the bug in the Summary section. And when you do so, you'll want to put it in the form of "BUG: 382512" on its own line; this will cause that bugzilla ticket to automatically get closed if and when this lands. The Summary section should also receive a longer explanation of the change, if necessary. Also, please write something in the Test Plan section describing how you tested this change. Thanks again for the patch, and don't hesitate to ask if anything's unclear!
For patch it seems ok.
But Nathaniel is right. Describe how you tested it, add BUG: etc.
Otherwise it's a good start :)
Thanks.