Differential D10148

KCM: Show only available device profiles
ClosedPublic
Actions

Authored by drosca on Jan 27 2018, 5:54 PM.

Details

Reviewers
nicolasfella
Group Reviewers
Plasma
Commits
R994:1e644e5723df: KCM: Show only available device profiles
R115:1e644e5723df: KCM: Show only available device profiles
Summary

^
CCBUG: 365723

Test Plan

Unavailable profiles are now filtered out

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Jan 27 2018, 5:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 27 2018, 5:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca requested review of this revision.Jan 27 2018, 5:54 PM
broulik added a subscriber: broulik.Feb 2 2018, 8:39 PM
broulik added inline comments.
src/kcm/package/contents/ui/CardListItem.qml
57–59
model: Profiles.filter(function (profile) {
    return profile.availability === Profile.Available;
})
nicolasfella requested changes to this revision.Feb 2 2018, 9:58 PM
nicolasfella added a subscriber: nicolasfella.

This leads to the wrong profile being selected. Because some profiles are excluded from the model the indices don't match anymore.

This revision now requires changes to proceed.Feb 2 2018, 9:58 PM
drosca updated this revision to Diff 26480.Feb 4 2018, 8:26 AM

Fixed issues

nicolasfella accepted this revision.Feb 4 2018, 1:01 PM

Looks good to me

This revision is now accepted and ready to land.Feb 4 2018, 1:01 PM
ngraham added a subscriber: ngraham.Feb 4 2018, 9:20 PM

Does this fully fix 365723? And if not, what more is needed there?

Closed by commit R115:1e644e5723df: KCM: Show only available device profiles (authored by drosca). · Explain WhyFeb 10 2018, 12:50 PM
This revision was automatically updated to reflect the committed changes.
drosca added a comment.Feb 10 2018, 12:51 PM

@ngraham It needs "better" filtering as suggested in the bugreport.

Revision Contents
Changeset List

Diff 26865

View Options

src/kcm/package/contents/ui/CardListItem.qml

Loading...