Differential D10140

Make Android app compilable with C++14 and later
ClosedPublic
Actions

Authored by jnadal on Jan 27 2018, 11:37 AM.

Details

Reviewers
johanneszarl
Group Reviewers
KPhotoAlbum
Commits
R463:22666bb6663d: Make Android app compilable with C++14 and later
Summary

Due to changes in std consturctors in C++14, file History.cpp does not compile anymore when targeting C++14 or later.

Details in this StackOverflow question.

I am unsure if the Android KPhotoAlbum app should be compatible with C++14 or stay with C++11.

Diff Detail

Repository
R463 KPhotoAlbum
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jnadal requested review of this revision.Jan 27 2018, 11:37 AM
jnadal created this revision.
johanneszarl accepted this revision.Jan 27 2018, 7:57 PM
johanneszarl added a subscriber: johanneszarl.

KPhotoAlbum should be compatible with both C++11 and C++14. Your change works with both, so: ship it!

This revision is now accepted and ready to land.Jan 27 2018, 7:57 PM
Closed by commit R463:22666bb6663d: Make Android app compilable with C++14 and later (authored by johanneszarl). · Explain WhyFeb 11 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MAndroidRemoteControl/History.cpp (2 lines)

Diff 26956

View Options

AndroidRemoteControl/History.cpp

Loading...