Update KMyMoney blueprint
ClosedPublic
Actions

Authored by wojnilowicz on Jan 27 2018, 11:36 AM.

Details

Reviewers

vonreth

Commits

R877:6c9a55ff5fae: Update KMyMoney blueprint

Summary

Added some more dependencies and disabled testing when not in continuous
integration to save some time.

Test Plan

I tested building KMyMoney on 5.0 branch with additional patches.

Repository

R877 Craft Blueprints for KDE

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Jan 27 2018, 11:36 AM

wojnilowicz created this revision.

KMyMoney 5.0 branch is ready for testing with Craft on MSVC 2017.
Would it be possible to prepare KMyMoney Windows installer as for KDevelop here?
https://binary-factory.kde.org/job/kdevelop-stable-win64/

vonreth requested changes to this revision.Jan 28 2018, 1:15 PM

vonreth added inline comments.

extragear/kmymoney/kmymoney.py
51	Please remove that code. Tests should be disabled by locally setting https://github.com/KDE/craft/blob/master/CraftSettings.ini.template#L74

This revision now requires changes to proceed.Jan 28 2018, 1:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 1 2018, 3:12 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			extragear/kmymoney/kmymoney.py (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26043			Jan 27 2018, 11:35 AM	★	★
Diff 2	26125			Jan 28 2018, 1:39 PM	★	★
Diff 3	26324	0408c68	R877:6c9a55ff5fae4725e2dadbd2ddbf15dc79048165	Feb 1 2018, 3:12 PM	★	★