Fix unused parameters warnings
ClosedPublic

Authored by arrowd on Jan 26 2018, 3:41 PM.

Diff Detail

Repository
R59 KDevelop Go
Lint
Lint Skipped
Unit
Unit Tests Skipped
huguesmorisset created this revision.Jan 26 2018, 3:41 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 26 2018, 3:41 PM
huguesmorisset requested review of this revision.Jan 26 2018, 3:41 PM
huguesmorisset retitled this revision from Change call to openDeclaration to send an Identifier instead of an QualifiedIdentifier to Fix compiler warnings.
huguesmorisset edited the summary of this revision. (Show Details)
huguesmorisset retitled this revision from Fix compiler warnings to Fix unused parameters warnings.Jan 26 2018, 4:02 PM
huguesmorisset edited the summary of this revision. (Show Details)
kfunk requested changes to this revision.Mar 22 2018, 6:20 AM
kfunk added a subscriber: kfunk.
  • Please remove unused code altogether, don't just comment
  • Please use Q_UNUSED(var) to mark var as an unused parameter
This revision now requires changes to proceed.Mar 22 2018, 6:20 AM
arrowd commandeered this revision.Jan 3 2019, 4:30 PM
arrowd added a reviewer: huguesmorisset.
arrowd updated this revision to Diff 48608.Jan 3 2019, 4:34 PM

Refresh diff and address comments.

kfunk accepted this revision.Jan 12 2019, 12:21 PM

LGTM

codecompletion/context.cpp
525

\ needs to rm'd as well?

This revision is now accepted and ready to land.Jan 12 2019, 12:21 PM
This revision was automatically updated to reflect the committed changes.
arrowd marked an inline comment as done.Jan 12 2019, 6:47 PM