Port konsolesessions runner to Plasma5/Qt5
ClosedPublic
Actions

Authored by kossebau on Jan 26 2018, 1:42 AM.

Details

Reviewers

broulik
jriddell
davidedmundson

Commits

R114:2f3bcfa8c61d: Port konsolesessions runner to Plasma5/Qt5

Summary

Ported following changes in katesessions runner and konsole.

Test Plan

Konsole profiles are shown as matches when entering "konsole"
and "konsole <lettersofprofiles>"

Diff Detail

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jan 26 2018, 1:42 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 26 2018, 1:42 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

kossebau requested review of this revision.Jan 26 2018, 1:42 AM

Actually this runner plugin is misnomed, it does not deal with konsole sessions, but with profiles.

Did not do any renaming in the port to keep port changes understandable, but would do a follow-up renaming of code and plugin name, with all "session" -> "profile".

good stuff

This revision is now accepted and ready to land.Jan 26 2018, 4:47 PM

Closed by commit R114:2f3bcfa8c61d: Port konsolesessions runner to Plasma5/Qt5 (authored by kossebau). · Explain WhyJan 26 2018, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			runners/CMakeLists.txt (10 lines)
M			runners/konsolesessions/CMakeLists.txt (14 lines)
M			runners/konsolesessions/konsolesessions.h (22 lines)
M			runners/konsolesessions/konsolesessions.cpp (112 lines)