signalplotter: Use std namespaced isnan and isinf
ClosedPublic
Actions

Authored by drosca on Feb 23 2016, 4:38 PM.

Details

Reviewers

ivan

Group Reviewers

Plasma

Commits

Test Plan

Fixes build for me.

Repository

R111 KSysguard Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca retitled this revision from to signalplotter: Use std namespaced isnan and isinf.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

What build issue did you have? Was <cmath> change not enough?

error: ‘isnan’ was not declared in this scope

No, changing to cmath is not enough. Actually it builds even without including cmath, so some other header must include it.

I'd say it should be ok with std:: for standard-compliant compilers. I hope we will not have issues due to some strange compiler.

This revision is now accepted and ready to land.Feb 23 2016, 5:35 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			signalplotter/ksignalplotter.cpp (34 lines)
M			tests/signalplottertest.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2441	45e660d		Feb 23 2016, 4:38 PM	★	★
Diff 2	2447	45e660d	rLIBKSYSGUARDb0578798eb3f5bdad0a25ea9b4a52c53ebcfc020	Feb 23 2016, 6:05 PM	★	★