The MouseArea for allowing middle click to mute overrules the cursorShape of the draggable area.
By moving the middle click area to the right of the icon, we avoid this and can change the cursor to an open hand when hovering the icon to indicate something draggable. The drag area can still be middle clicked to mute.
Details
Details
- Reviewers
drosca - Group Reviewers
Plasma VDG - Commits
- R994:3c70f04ebe8a: Fix drag cursor
R115:3c70f04ebe8a: Fix drag cursor
- Verified hand cursor does not show up when it cannot be dragged (device list or only one device in application list)
- Verified that left pressing mouse changes cursor to closed hand on drag area
- Verified middle pressing mouse does not change cursor on drag area
- Verified drag and drop to send applications to other audio devices still works
- Verified that middle click on the list item still mutes/unmutes
- Verified that middle click on the icon still mutes/unmutes
- Verified that layout is correct with layout mirroring
There's now a little gap above and below the icon where you can no longer middle click to mute/unmute but that's negligible imho as there's nothing visually there.
Note the little dead area
Open hand cursor over the icon, it "closes" when pressed. The green area is obviously not part of this patch.
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.