[Image Wallpaper] Make color picker visible for all positioning mode.
ClosedPublic

Authored by bdhruve on Feb 22 2016, 2:13 PM.

Details

Summary

If user is using svg wallpaper with opaque area, then this allows users to fill opaque area with color.
Bug: 351012.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bdhruve updated this revision to Diff 2432.Feb 22 2016, 2:13 PM
bdhruve retitled this revision from to [Image Wallpaper] Make color picker visible for all positioning mode..
bdhruve updated this object.
bdhruve edited the test plan for this revision. (Show Details)
bdhruve added a reviewer: Plasma.
bdhruve set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2016, 2:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

You would also need to adjust:

  • Line 298: remove the visible check to always set the appropriate color
  • main.qml, Lines 196ff: the background color rect also needs to be visible in all modes
wallpapers/image/imagepackage/contents/ui/config.qml
136

You can just omit this line, visible defaults to true

bdhruve updated this revision to Diff 2436.Feb 23 2016, 7:42 AM

Fix issues mentioned by broulik.

bshah accepted this revision.Feb 25 2016, 2:52 AM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

Looks good to me, I will submit this patch in master branch.

Congratulations on your first patch to KDE.

This revision is now accepted and ready to land.Feb 25 2016, 2:52 AM
This revision was automatically updated to reflect the committed changes.