Differential D10084

Make the messages translatable
ClosedPublic
Actions

Authored by yurchor on Jan 24 2018, 6:29 PM.

Details

Reviewers
graesslin
lueck
Group Reviewers
Plasma
Localization
Commits
R129:64d9f92f6a87: Make the messages translatable
Summary

Currently, there is no extraction of messages and no actual translation.

This patch by Victor <victorr2007@narod.ru> tries to solve this issue.

Update: removed duplication.

Test Plan

Extraction tested to work correctly.

Diff Detail

Repository
R129 Window Decoration Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Jan 24 2018, 6:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2018, 6:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yurchor requested review of this revision.Jan 24 2018, 6:29 PM
aacid added a subscriber: aacid.Jan 24 2018, 6:50 PM
aacid added inline comments.
CMakeLists.txt
71

isn't this already on line 41?

yurchor updated this revision to Diff 25908.Jan 24 2018, 7:18 PM
yurchor edited the summary of this revision. (Show Details)
yurchor marked an inline comment as done.Jan 25 2018, 11:04 AM

I have removed the duplicate. Thanks.

lueck accepted this revision.Jan 26 2018, 5:33 AM
lueck added a subscriber: lueck.

Thanks

This revision is now accepted and ready to land.Jan 26 2018, 5:33 AM
Closed by commit R129:64d9f92f6a87: Make the messages translatable (authored by yurchor). · Explain WhyJan 26 2018, 8:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/CMakeLists.txt (2 lines)
AMsrc/Messages.sh (2 lines)

Diff 25983

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/Messages.sh

Loading...