Don't assert if used incorrectly from dbus
ClosedPublic
Actions

Authored by graesslin on Jan 24 2018, 5:01 PM.

Details

Reviewers

apol
romangg

Group Reviewers

Frameworks

Commits

Summary

The component dbus interface allowed to remote kill the wayland session
by sending an incorrect request to the kglobalaccel dbus interface.

There is no point in asserting, the code must be able to handle error
cases and also is able to handle them.

BUG: 389375
FIXED-IN: 5.43

Repository

R268 KGlobalAccel

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin requested review of this revision.Jan 24 2018, 5:01 PM

romangg added inline comments.

src/runtime/component.cpp
250–251	Also always false.

Remove the usless assert Roman found

ping

This revision is now accepted and ready to land.Feb 22 2018, 1:44 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/runtime/component.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25895	147acd2		Jan 24 2018, 5:01 PM	★	★
Diff 2	26098	147acd2	Remove the usless assert Roman found	Jan 28 2018, 9:00 AM	★	★
Diff 3	28562	fef84b0	R268:7d272782a55e3c98bdd0b4181958f64f312aa3d9	Mar 4 2018, 8:45 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
bdf7f12dd116	deb30e118a62	147acd294dd0	Martin Flöser	Don't assert if used incorrectly from dbus (Show More…)	Jan 24 2018, 4:59 PM