| aacid |
| Okular |
This adds a new data object "Event" that can be used
to carry information in and out of JavaScript execution
contexts. The Event Object is defined in the Adobe JavaScript
scripting reference.
The implementation now adds handling for the FieldCalculate
Event. It should be extensible enough so that in the future
more events could be supported.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| core/script/kjs_field.cpp | ||
|---|---|---|
| 222 ↗ | (On Diff #25874) | You really want ot use the verison with the page so refreshPixmaps happens |
Carried the source / target page through to have it available when the kjs_fields are created.
| core/script/kjs_field.cpp | ||
|---|---|---|
| 222 ↗ | (On Diff #25874) | Indeed I want that now. :-) This required an ugly const cast though as the kjs_field API works with a non const Page pointer. Maybe that could / should be changed? |
| core/script/kjs_field.cpp | ||
|---|---|---|
| 222 ↗ | (On Diff #25874) | Or just don't store the page as const pointer? |
| core/script/kjs_field.cpp | ||
|---|---|---|
| 222 ↗ | (On Diff #25874) | I passed it as const as I only saw API in document to get a const page reference and recalculateForms also used a const reference. I'll change it. |
| core/script/kjs_field.cpp | ||
|---|---|---|
| 217 ↗ | (On Diff #27264) | Why the new if? |
| core/script/kjs_field.cpp | ||
|---|---|---|
| 217 ↗ | (On Diff #27264) | It is not assured in kjs_event.cpp eventGetSource and eventGetTarget that the targetPage / sourcePage is not null. This depends a how the event object is set up. Although I think that sourcePage "should" be set when source is set and targetPage should be set if target is set there is no guarantee for this and so I think a check here is warranted. |
| core/script/kjs_field.cpp | ||
|---|---|---|
| 217 ↗ | (On Diff #27264) | No, no check is warranted, if page is null is because the code is wrong and it should crash so we can fix it not silently do nothing. |