Support ECMA-48 REP
ClosedPublic

Authored by btown on Jan 24 2018, 12:27 AM.

Details

Summary

From lxde/qtermwidget@60221da by @yan12125: Support ECMA-48 REP. I tried to make the changes follow existing styles and conventions.

ECMA-48 8.3.103 describes the sequence CSI Pₙ b for repeating the previous character in the data stream. This sequence has been present in XTerm since January 1997 and has been added to the latest terminfo entry for xterm-new and derived entries such as xterm-256color.

Test Plan

Tested manually with sequences such as:

x\e[by  <- default is repeat once
x\e[0by  <- 0 means "default", which is repeat once
x\e[4by
 \e[4by  <- space
a™\e[4bz  <- U+2122 TRADE MARK SIGN

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
btown created this revision.Jan 24 2018, 12:27 AM
Restricted Application added a subscriber: Konsole. · View Herald TranscriptJan 24 2018, 12:27 AM
btown requested review of this revision.Jan 24 2018, 12:27 AM
wbauer added a subscriber: wbauer.Jan 24 2018, 12:46 PM

This would fix https://bugs.kde.org/show_bug.cgi?id=384620, right?
Then please add "BUG: 384620" to your description (on a separate line), so that the bug report will get closed automatically.

This would fix https://bugs.kde.org/show_bug.cgi?id=384620, right?
Then please add "BUG: 384620" to your description (on a separate line), so that the bug report will get closed automatically.

PS, I tried it and it does work with the example mentioned in that bug report (with latest ncurses).

I'm not konsole's maintainer though... ;-)

looks fine - only issue is the part about a "normal" program only using this with a visible char - should that be checked? For example, if the previous char is the bell \007 I'm not clear on where it picked up the char it printed Ps times

hindenburg accepted this revision.Feb 3 2018, 6:05 PM

OK from my testing, I don't see any issues

This revision is now accepted and ready to land.Feb 3 2018, 6:05 PM
hindenburg closed this revision.Mar 1 2018, 3:12 PM

another bad commit message didn't close this

b8a2f0cfd0d0f894687953c3f50f2fb163e8690d