Require libinput and udev
ClosedPublic

Authored by graesslin on Jan 23 2018, 5:17 PM.

Details

Reviewers
None
Group Reviewers
KWin
Plasma
Commits
R108:bbf00fdd9808: Require libinput and udev
Summary

The main reason for not having it as a mandatory dependency was that BSD
doesn't support it. But as I learned recently it is available on our CI
system. So BSDs have support now.

Even more it showed that the code doesn't compile if the dependency is
missing. And there's one thing I hate: broken build configuration
options.

So let's make UDEV and libinput a required dependency and get rid of the
problems.

Test Plan

Compiles

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jan 23 2018, 5:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 23 2018, 5:17 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Jan 23 2018, 5:17 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 23 2018, 5:17 PM
mart added a subscriber: mart.Jan 26 2018, 1:03 PM

+1 from me

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 26 2018, 1:03 PM

If nobody objects by Sunday I'm going to push this.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 1 2018, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2018, 2:07 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 4 2018, 2:07 PM