Differential D10049

[PATCH 3/4] Add initial support for built-in javascript functs
ClosedPublic
Actions

Authored by aheinecke on Jan 23 2018, 1:52 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T7805: Okular: Add support for JavaScript AFSimple_Calculate and textfield content calculation

Commits

R223:cead2bbef3c2: Add initial support for built-in javascript functs

Summary

This starts by adding support for AFSimple_Calculate which
is the standard "calculate" function in Adobe Acrobat Pro.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

aheinecke requested review of this revision.Jan 23 2018, 1:52 PM

aheinecke created this revision.

aheinecke added a task: T7805: Okular: Add support for JavaScript AFSimple_Calculate and textfield content calculation.

Updated to use Event Object

aacid added a subscriber: aacid.Feb 3 2018, 7:59 PM

aacid added inline comments.

core/script/builtin.js
36	why set ret to 1 if ret is 0? is this because you want to initialize? then you should test i is 0 otherwise 304 will be 4?

Fix first grade math error. *blushes*

aheinecke marked an inline comment as done.Feb 8 2018, 1:53 PM

aheinecke added inline comments.

core/script/builtin.js
36	Indeed and nice catch :-). For PRD I wanted to set the start value to 1 and not 0. I made this more explicit now.

aacid accepted this revision.Feb 21 2018, 11:18 PM

This revision is now accepted and ready to land.Feb 21 2018, 11:18 PM

Closed by commit R223:cead2bbef3c2: Add initial support for built-in javascript functs (authored by aheinecke, committed by aacid). · Explain WhyFeb 21 2018, 11:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (4 lines)
A	M		core/script/builtin.js (62 lines)
A	M		core/script/builtin.qrc (5 lines)
M			core/scripter.cpp (18 lines)

Diff 27741

CMakeLists.txt

Loading...

core/script/builtin.js

Loading...

core/script/builtin.qrc

Loading...

core/scripter.cpp

Loading...