Add support of drag-and-drop to open files

Authored by guotao on Jan 23 2018, 7:48 AM.



Add support of drag-and-drop to open files.
When first open okteta, drag files to the blank view area to open files

Test Plan

drag and drop to open files

Diff Detail

R457 Okteta
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
guotao requested review of this revision.Jan 23 2018, 7:48 AM
guotao created this revision.
guotao retitled this revision from Add drag-and-drop to open files to Add support of drag-and-drop to open files.Jan 23 2018, 7:53 AM
guotao edited the summary of this revision. (Show Details)
guotao edited the test plan for this revision. (Show Details)
guotao added a reviewer: KDE Developers.
bcooksley edited reviewers, added: kossebau; removed: KDE Developers.Jan 23 2018, 7:54 AM
bcooksley added a subscriber: bcooksley.

The KDE Developers group is mostly for access control purposes in the future. I've added @kossebau who if my memory serves looks after Okteta.

Thanks for coming up with a patch. I remember some support for DnD of file urls to load onto Okteta was lost in the porting to Qt5, never noticed this basic one as well. Will be good to have it back.

On my review TODO for this WE, if not tonight.

kossebau accepted this revision.Feb 2 2018, 1:51 PM

Thanks for the patch. Do you have commit push rights for KDE accounts?
If not, I will push for you. Please tell your full name and email address, so it can be used for the commit author data.

Your patch actually inspired me to look into restoring more DnD functionality, so chances is some parts will be changed soon.
But for now your patch will ensure this basic DnD support is back :)


Should be like this for consistency:

emit receivedDropEvent(event);
This revision is now accepted and ready to land.Feb 2 2018, 1:51 PM
guotao updated this revision to Diff 26553.Feb 5 2018, 1:52 AM
guotao marked an inline comment as done.

Update patch

guotao added a comment.Feb 5 2018, 1:59 AM

Hello, kossebau

I have no commit push rights. You can push this commit to git use below info:
Tao Guo <>

Thank you

This revision was automatically updated to reflect the committed changes.