make it compile
ClosedPublic
Actions

Authored by mkoller on Jan 22 2018, 7:14 PM.

Details

Reviewers

dvratil
mlaurent

Commits

R168:e25ecd1325da: make it compile with clang5

Summary

clang version 5.0.0 (tags/RELEASE_500/final 312548)
Qt 5.10, openSuse 42.2

[ 91%] Building CXX object src/conf/CMakeFiles/kcm_kleopatra.dir/appearanceconfigpage.cpp.o
/home/KDE5/source/kde/pim/kleopatra/src/conf/appearanceconfigpage.cpp:52:89: error: 'changed' is a protected member of 'KCModule'

connect(mWidget, &AppearanceConfigWidget::changed, this, QOverload<>::of(&KCModule::changed));
                                                                          ~~~~~~~~~~^~~~~~~

/usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member using the type of the current context 'Kleo::Config::AppearanceConfigurationPage'

void changed();
     ^

1 error generated.

etc.

Diff Detail

Repository

R168 Kleopatra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mkoller created this revision.Jan 22 2018, 7:14 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 22 2018, 7:14 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

mkoller requested review of this revision.Jan 22 2018, 7:14 PM

mlaurent accepted this revision.Jan 23 2018, 6:46 AM

This revision is now accepted and ready to land.Jan 23 2018, 6:46 AM

Closed by commit R168:e25ecd1325da: make it compile with clang5 (authored by mkoller). · Explain WhyJan 23 2018, 7:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/conf/appearanceconfigpage.cpp (2 lines)
M			src/conf/cryptooperationsconfigpage.cpp (2 lines)
M			src/conf/gnupgsystemconfigurationpage.cpp (2 lines)
M			src/conf/smimevalidationconfigurationpage.cpp (2 lines)