Removed duplicate preview screenshots
ClosedPublic

Authored by anemeth on Jan 22 2018, 5:58 PM.

Details

Summary

Now it checks if the preview screenshot URL is already in the list.
Sometimes it happens that preview1 and preview2 are the same URL.

Test Plan

Before:

After:

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.Jan 22 2018, 5:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 22 2018, 5:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anemeth requested review of this revision.Jan 22 2018, 5:58 PM
anemeth edited the summary of this revision. (Show Details)Jan 22 2018, 6:03 PM
anemeth edited the test plan for this revision. (Show Details)
apol requested changes to this revision.Jan 22 2018, 6:05 PM

Please modify appendIfValid to not add duplicates.

This revision now requires changes to proceed.Jan 22 2018, 6:05 PM
In D10027#194443, @apol wrote:

Please modify appendIfValid to not add duplicates.

What do you mean?
In what situation would it add duplicates?
This change is to make sure it does not add duplicates.

ngraham added a subscriber: ngraham.EditedJan 22 2018, 6:10 PM
In D10027#194443, @apol wrote:

Please modify appendIfValid to not add duplicates.

What do you mean?
In what situation would it add duplicates?
This change is to make sure it does not add duplicates.

I think Aleix is saying that you should make the change inside appendIfValid() instead of duplicating 4 times the same code that calls appendIfValid().

Thanks for the patch, BTW!

anemeth updated this revision to Diff 25774.Jan 22 2018, 6:40 PM

Now I see what you mean. :)
That makes it a lot smaller.

anemeth updated this revision to Diff 25776.Jan 22 2018, 6:43 PM

Checking for duplicate now added to appendIfValid() instead

davidedmundson accepted this revision.Jan 22 2018, 9:31 PM
apol accepted this revision.Jan 22 2018, 11:44 PM
This revision is now accepted and ready to land.Jan 22 2018, 11:44 PM
apol added a comment.Jan 22 2018, 11:44 PM

Can you push?

apol added a comment.Jan 22 2018, 11:45 PM

Please land on the 5.12 branch.

abetts accepted this revision.Jan 22 2018, 11:46 PM

I don't think I have push access.
Can you do it instead?

This revision was automatically updated to reflect the committed changes.