Differential D10023

Improve display of long app captions and name/caption padding
ClosedPublic
Actions

Authored by ngraham on Jan 22 2018, 3:10 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
VDG
Commits
R134:5583b17d2c13: Improve display of long app captions and name/caption padding
Summary
  • Reduce padding between app name and caption to connect them a bit better
  • Allow app caption string to have up to two lines when it's long and the window is narrow
Test Plan

Tested in NDE Neon.

Blender, before:

Blender, after:

LibreOffice Writer, before:

LibreOffice Writer, after:

GIMP, before:

GIMP, after:

Diff Detail

Repository
R134 Discover Software Store
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Jan 22 2018, 3:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 22 2018, 3:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 22 2018, 3:10 PM
ngraham edited the test plan for this revision. (Show Details)Jan 22 2018, 3:13 PM
apol requested changes to this revision.Jan 22 2018, 3:19 PM
apol added inline comments.
discover/qml/ApplicationPage.qml
157

That's the default, no need to insist on it.

167

Is it really necessary? I wouldn't change the default at least to 1.2, leave 1.0 as it's the level 4 font.

This revision now requires changes to proceed.Jan 22 2018, 3:19 PM
apol accepted this revision.Jan 22 2018, 3:33 PM
This revision is now accepted and ready to land.Jan 22 2018, 3:33 PM
ngraham closed this revision.Jan 22 2018, 3:34 PM

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ApplicationPage.qml (4 lines)

Diff 25762

View Options

discover/qml/ApplicationPage.qml

Loading...