PictureShape: fix CropWidget rendering
ClosedPublic

Authored by pettke on Jan 21 2018, 10:29 PM.

Details

Reviewers
danders
Group Reviewers
Calligra: 3.0
Summary

Paint crop rectangle and its handles with 1px wide outline.
Due to the painter scaling the pen width (1 by default) was scaled too, which caused the outlines to cover the whole image.

This patch sets the pen width to 0 which always results in a 1px wide line, unfortunately also on HiDPI-Displays.
Using a pen width of 1 and changing everything to work with absolute coordinates to fix that seemed a little cumbersome, so I added a dark overlay for the cropped region to improve visibility instead.

Fixes Bug 388930

Diff Detail

Repository
R8 Calligra
Lint
Lint Skipped
Unit
Unit Tests Skipped
pettke created this revision.Jan 21 2018, 10:29 PM
Restricted Application added a project: Calligra: 3.0. ยท View Herald TranscriptJan 21 2018, 10:29 PM
pettke requested review of this revision.Jan 21 2018, 10:29 PM
danders accepted this revision.Jan 23 2018, 9:37 AM
danders added a subscriber: danders.

Looks good.

This revision is now accepted and ready to land.Jan 23 2018, 9:37 AM
danders closed this revision.Mar 23 2018, 7:44 AM

I commited this, the review was just not closed.