Improve header and screenshots
ClosedPublic

Authored by ngraham on Jan 21 2018, 3:50 AM.

Details

Summary

Taking inspiration from @abetts popular idea for some tweaks, I implemented a few changes to the Application page:

  • Increased size of app icon, name, and caption
  • Removed blue line separating header and screenshots/description, since it was controversial and kind of pointless and inconsistent when the metadata section didn't have a text header
  • Displayed screenshot thumbnails with the aspect ratio of the full-sized image, so they look better and nothing is cut off in the thumbnail
  • Gave screenshot thumbnails a drop shadow and more padding between them

Errata:

  • The screenshots lost their hover effect as a side effect of the way the QML DropShadow effect had to be implemented. I tried many ways of adding it, and this was the way that caused the last amount of damage. Definitely open to suggestions.
Test Plan

Tested in KDE Neon:

Pitivi, before:

Pitivi, after:

Audacity, before:

Audacity, after:

Clementine, before:

Clementine, after:

Mobile view Kdenlive, before:

Mobile view Kdenlive, after:

Mobile view Endless Sky, before:

Mobile view Endless Sky, after:

Mobile View gedit, before:

Mobile View gedit, after:

Diff Detail

Repository
R134 Discover Software Store
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Jan 21 2018, 3:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 21 2018, 3:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 21 2018, 3:50 AM
ngraham edited the test plan for this revision. (Show Details)Jan 21 2018, 3:52 AM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the summary of this revision. (Show Details)Jan 21 2018, 4:03 AM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the summary of this revision. (Show Details)

I know it seems like we're just changing the design over and over again, but IMHO this is an improvement over what I proposed and landed a few days ago--being even more true to the visual language we've established.

Also, I want the version of Discover in Plasma 5.12 that Debian and Ubuntu users get stuck with for 5 years to be really, really nice looking.

abetts accepted this revision.Jan 21 2018, 4:13 AM
This revision is now accepted and ready to land.Jan 21 2018, 4:13 AM
apol accepted this revision.Jan 21 2018, 2:10 PM
ngraham closed this revision.Jan 21 2018, 3:43 PM