korgac: Make the korgac notification dialog even smaller
ClosedPublic
Actions

Authored by dfries on Oct 16 2018, 3:50 AM.

Details

Reviewers

Summary

The existing comment was
// Try to keep the dialog small and non-obtrusive.
but it prevented the user form making it even smaller.
Make the minimum size smaller than the initial size, and enable
options to take less space for it be even smaller.

Test Plan

Take a screen shot of the Reminders window before applying change (I get a size of 583x321), notice the window doesn't get smaller, apply change, notice it is smaller (I get 432x208), notice the window now can get even smaller (I get down to 288x181).

Diff Detail

Repository

R210 KOrganizer

Lint

Lint Skipped

Unit

Unit Tests Skipped

dfries created this revision.Oct 16 2018, 3:50 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 16 2018, 3:50 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dfries requested review of this revision.Oct 16 2018, 3:50 AM

mlaurent requested changes to this revision.Oct 16 2018, 4:55 AM

mlaurent added inline comments.

korgac/alarmdialog.cpp
209	setMinimunSize ?
214	no stylesheet please as it will break with some style.

This revision now requires changes to proceed.Oct 16 2018, 4:55 AM

dvratil added a subscriber: dvratil.Oct 16 2018, 8:31 AM

dvratil added inline comments.

korgac/alarmdialog.cpp
211	I wonder, how does this work with HiDPI? Should this be multiplied by DPI or some other factor? 424px on HiDPI screen would be super-tiny.

inline comment

korgac/alarmdialog.cpp
211	If 424 would be super-tiny, would be only super-tiny*1.36. I don't have a HiDPI monitor to test, but I see, korgacmain.cpp: QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling); and if I run with the environment variable QT_SCALE_FACTOR=2 everything is super huge. What do you think? highdpi.html

dvratil added inline comments.Oct 16 2018, 1:56 PM

korgac/alarmdialog.cpp
211	Cool, so Qt scales this up for us. In that case 👍

will update the patch...

korgac/alarmdialog.cpp
214	Removing setStyleSheet has the biggest effect on making the buttons larger, but not much on the overall size, removing the setStyleSheet line.

updated with the two requested changes, setMinimumSize, remove setStyleSheet

dfries added a dependency: D16240: korgac: remove m prefix for local variable topLayout.Oct 18 2018, 4:25 AM

dfries added a dependent revision: D16245: korgac: Save size and position on dialog hide/close and improve restore.

dfries mentioned this in D16240: korgac: remove m prefix for local variable topLayout.Oct 18 2018, 4:32 AM

it seems ok for me.

This revision is now accepted and ready to land.Oct 18 2018, 5:20 AM

dfries mentioned this in D16245: korgac: Save size and position on dialog hide/close and improve restore.Oct 25 2018, 5:38 PM

mlaurent closed this revision.Oct 26 2018, 5:33 AM

Revision Contents
Changeset List

			Path	Packages
M			korgac/alarmdialog.cpp (18 lines)

Status	Author	Revision
Closed	dfries	D16247 korgac: Call setOnAllDesktops from showEvent
Needs Review	dfries	D16246 korgac: For no grab avoid mouse cursor when placing window
Closed	dfries	D16245 korgac: Save size and position on dialog hide/close and improve restore
Closed	dfries	D16244 korgac: Make the korgac notification dialog even smaller
Closed	dfries	D16243 korgac: Add a menu option to always get to the reminder dialog.
Closed	dfries	D16242 korgac: Add an option to not grab keyboard focus when a reminder is displayed
Closed	dfries	D16240 korgac: remove m prefix for local variable topLayout

Diff 43778

View Options

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	43714		Oct 16 2018, 3:39 AM	★	★
Diff 2	43778		Oct 17 2018, 3:50 AM	★	★

korgac: Make the korgac notification dialog even smallerClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 43778

korgac/alarmdialog.cpp

korgac: Make the korgac notification dialog even smaller
ClosedPublic
Actions

Revision Contents
Changeset List