Differential D27129

[Notifications] Allow expiring an entire group
AcceptedPublic
Actions

Authored by broulik on Feb 3 2020, 3:48 PM.

Details

Reviewers
meven
Group Reviewers
Plasma
Summary

Similar to how we can close an entire group at once.
This is in preparation for being able to have groups in the popup as well.

Test Plan
  • Invoked expire on a group, had all items expire

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 3 2020, 3:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2020, 3:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 3 2020, 3:48 PM
broulik updated this revision to Diff 74930.Feb 3 2020, 3:51 PM
  • Don't expire when already expired
broulik added a comment.Feb 7 2020, 9:26 AM

Hmm just crashed on me:

#6  0x00007f7a94c1cdf4 in NotificationManager::NotificationGroupingProxyModel::index(int, int, QModelIndex const&) const (this=0x555f621dd0e0, row=0, column=<optimized out>, parent=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:241
#7  0x00007f7a94c0e92f in NotificationManager::Notifications::expire(QModelIndex const&) (this=0x555f621c08b0, idx=...) at /home/kaiuwe/Projekte/kf5/plasma-workspace/libnotificationmanager/notifications.cpp:672
broulik added a comment.Jun 7 2020, 10:36 AM

Should we go with this now? I haven't seen it crash on me since I fixed the checkIndex thing

meven accepted this revision as: meven.Jun 7 2020, 11:30 AM
meven added a subscriber: meven.

Seems fine to me

This revision is now accepted and ready to land.Jun 7 2020, 11:30 AM

Revision Contents
Changeset List

Diff 74930

View Options

libnotificationmanager/notifications.cpp

Loading...