User Details
- User Since
- Feb 11 2019, 9:22 AM (273 w, 4 d)
- Availability
- Available
Feb 28 2019
cool thanks :)
Feb 22 2019
Yeah, I just missed to recheck the sorting logic. Before the change we just needed the best match so the partial sort was completely sufficient. Now we need a complete sorted vector, so stable sort is the way to go ;)
Feb 21 2019
Ah sorry completely missed that part. Unfortunately I'm out of office already, I'll take a look as soon as I'm back tomorrow.
Created https://phabricator.kde.org/D19200
That should implement all the latest suggestions/comments
Okay I've tested it with 3.12.2 and there were no issues.
I'm not familiar enough with cmake to tell whether there is a simpler version for what I try to achieve here. I just need the -D QT_NAMESPACE compiler options. Is there someone in the community who might know how to make it in a more elegant way.
If not I do not need that target_link_libraries part in Qt Creator, because we still only support building via qmake or qbs. It was just to be complete here. So it could be removed without breaking our use case, but it would break namespace builds for any one else.
Feb 14 2019
Nice respond times here, and thanks for the reviews :)
David Schulz david.schulz@qt.io
added additional context to the diff