I appreciate work on this issue.
I am not sure about how well this "hack" will solve the issue, thought.
I will give it a try here in any case.

Thanks ;=) Even with test.

Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended)
The current auto test file is autotests/input/highlight.lgt I assume.

Yes, please push, thanks!

Thanks for the fix + regression test!

Cool +1 ;=)
Thanks for the contribution.
We use that at company, nice to have.

Ok ;=)

True, guess I copied too large parts during my fix-up of this.

First let's have this, the current state is bad ;=)

For the example from the bug this makes the difference between ~30 seconds on a 4 Ghz machine to << 1 second ;=)

Better, but VHDL hl is still very slow, need to take a deeper look into it :/

Yes, I will fix the issues and then commit this as one thingy.
Thanks for taking a look :=)
My colleague was very unhappy with the VHDL performance :P
The highlighting shouldn't take as long as a hardware simulator.

remove useless output of stray azOffset var

Zoom is like all view stuff local, yes, I assume that is often not wanted.
But that is a orthogonal issue.
The same could be said for "dynamic word wrap", very seldom you want to set that for one view.
On the other side, for the global config, one has the settings dialog, same for "zoom", aka font size.

And btw., thanks a lot for taking care!
The vimode for sure has more need for love, if you have time ;=)

I think, one issue is, that <down> and <up> don't work that way in the test framework.
I reformulated the test with \down and \up and moved the asserts to verifies.
This works for me, will push this, please take a look if that is ok for you, too.

I will try to take a look as soon as I have time, if nobody else is faster.
Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails?

Hmm, yes, seems to work again.
Let's close this then again.

Hi, could it be that killed the inline notes autotest?

Thanks for working on this.
Badly scaled stuff is a real eyesore...

Ok, let's have that be in ;=)

Thanks for taking care of this!
Let's get that in.

Hmm, actually not sure why we didn't do that before.
I think this change makes sense.
Perhaps Dominik has some idea why we didn't do that in the past?
I myself think this change makes sense, but let's wait for Dominik's feedback before going forward.

Thanks, guess that should go in now.

Actually, one can re-use this regex for all files by moving it before the scope of the loop, or?
The match on the other side is allocated per match() call, I would just move that inside the inner stuff and just do some
const auto match = rx....

Thanks for this addition and the MIT licensing!

Ok, let's merge this.
Thanks for all the work on that!

Ok, let's land that.

Merged here

Upsa, true :(
Thanks for the fix!

Ok, then closing this again.

I think this should go in now. I think the usage of the API is correct even for HiDPI.
In KF6, we should just fold that interface into the main class.

Ok, makes sense, will increase version myself.

Thanks for the update!

Nice! Thanks for the improvements ;=)

Yes, sounds like a very good idea!
+1

Hi, nice that you keep working on this and upstream your stuff ;=)
Could you provide some test file for this?