Create Task
Maniphest T4157

can we get rid of qwidget in okularcore?
Open, Needs TriagePublic
Actions

aacid created this task.Oct 24 2016, 10:23 PM
aacid renamed this task from can we get rid of qwidet in okularcore? to can we get rid of qwidget in okularcore?.
apol added a subscriber: apol.Oct 29 2016, 8:43 AM

Can't do it just yet:

  • void Document::fillConfigDialog( KConfigDialog * dialog )
  • Plenty of KMessageBox in Document
core (frameworks)$ git grep -i dialog | grep include
chooseenginedialog.cpp:#include "chooseenginedialog_p.h"
chooseenginedialog.cpp:#include <QDialogButtonBox>
chooseenginedialog_p.h:#include <QDialog>
document.cpp:#include <QtPrintSupport/QPrintDialog>
document.cpp:#include "chooseenginedialog_p.h"
script/kjs_console.cpp:#include <kdialog.h>
apol added a comment.Oct 29 2016, 8:57 AM

More things:
class OKULARCORE_EXPORT TextDocumentSettingsWidget : public QWidget

For future us, to list used includes on headers:
grep core.*.h$ install_manifest.txt | xargs grep -h "^#include " | sort -u

aacid moved this task from KF5 porting to Backlog on the Okular board.Oct 29 2016, 2:38 PM