EditorView now displays attachments
ClosedPublic

Authored by ervin on Aug 11 2017, 10:59 PM.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Aug 11 2017, 10:59 PM
dfaure accepted this revision.Aug 12 2017, 10:04 PM
dfaure added inline comments.
src/widgets/editorview.cpp
120

why the else, given the return in the if block?

All the rest of the method is what happens with a model set, there's little reason to have some code in the else and some code after the else...

This revision is now accepted and ready to land.Aug 12 2017, 10:04 PM
ervin updated this revision to Diff 18113.Aug 13 2017, 11:06 PM

Addresses dfaure's comments

ervin updated this revision to Diff 18119.Aug 13 2017, 11:24 PM

Tune a bit the attachment list display

dfaure accepted this revision.Aug 14 2017, 10:54 AM
bensi accepted this revision.Aug 14 2017, 3:41 PM
This revision was automatically updated to reflect the committed changes.