Differential D28549

Describe error when querying Firefox places.sqlite for bookmarks
Needs ReviewPublic
Actions

Authored by abogical on Apr 4 2020, 3:07 AM.

Details

Reviewers
None
Group Reviewers
Falkon
Summary

Firefox places.sqlite database can still be opened even when Firefox is
running. However, it can't query the database, leaving an unhelpful
"No query Unable to fetch row" error after a long busy wait on the
database. This commit removes the busy wait and gives a more helpful
error.

Test Plan
  1. Run Firefox.
  2. Attempt to import bookmarks to Falkon.

Expect an error asking if Firefox is still running.

Diff Detail

Repository
R875 Falkon
Branch
firefox-running-warn
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24702
Build 24720: arc lint + arc unit
abogical created this revision.Apr 4 2020, 3:07 AM
Restricted Application added a project: Falkon. · View Herald TranscriptApr 4 2020, 3:07 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
abogical requested review of this revision.Apr 4 2020, 3:07 AM

Revision Contents
Changeset List

Diff 79258

View Options

src/lib/bookmarks/bookmarksimport/firefoximporter.cpp

Loading...