This slot was incorrectly made to last the lifetime of the slave. In fact, this
slot should only be live for the lifetime of the event loop (one I/O operation).
This can cause issues with the data being emitted for data from other IO
operations. By making it live in the lifetime of the local event loop this
scenario cannot occur as LIBMTP only allows one operation at a time.
Via the use of KIOFuse (as this is where the bug was noticed).
Before: Opening a file for the first time worked. Subsequent opens would fail
due to garbage output After: Opening any number of files at any time works.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
@apol just found another one where this occurs, forgot about it but noticed it earlier as well. This doesn't affect KIOFuse as much though (as we don't listen to the processedSize() signal).
I'll wait for another approval, or before 20.04 tagging, whichever comes first :P