Differential D28440

Mark KIOFuse mounts as Probably slow
ClosedPublic
Actions

Authored by feverfew on Mar 30 2020, 2:51 PM.

Details

Reviewers
dfaure
broulik
bruns
meven
Group Reviewers
Frameworks
Commits
R241:ec5adbccc23d: Mark KIOFuse mounts as Probably slow
Summary

Mark KIOFuse mounts as "Probably Slow". Note that this isn't always true,
there are plenty of slaves that simply refer to local files that can be
mounted in a KIOFuse mounts, but likewise, there are many slaves that
refer to network mounts that are slow, so better safe than sorry. And in
any case, the function is "probablySlow()", we don't have to confirm that
this is actually the case.

Test Plan

Compiles.
KIOFuse mounts indeed have a mount type of "fuse.kio-fuse"

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
feverfew created this revision.Mar 30 2020, 2:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 30 2020, 2:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
feverfew requested review of this revision.Mar 30 2020, 2:51 PM
meven accepted this revision.Mar 30 2020, 4:53 PM

Seems fine to me.

This revision is now accepted and ready to land.Mar 30 2020, 4:53 PM
broulik accepted this revision.Mar 30 2020, 4:55 PM

Makes sense since we generally don't want to access those directly anyway

Closed by commit R241:ec5adbccc23d: Mark KIOFuse mounts as Probably slow (authored by feverfew). · Explain WhyMar 30 2020, 5:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/kmountpoint.cpp (5 lines)

Diff 78920

View Options

src/core/kmountpoint.cpp

Loading...