Initial version for SPDX header detection
ClosedPublic

Authored by cordlandwehr on Feb 26 2020, 6:17 PM.

Details

Summary

This is a very simple solution to add the main SPDX based expressions
to the commit hook. For the main SPDX expressions, they specific
strings are detected, yet it does not really handle the full scope of
expressions.

The scope of this commit only is to avoid that any properly licensed file
is prevented from being pushed to our repositories, when a commonly
used SPDX expression is used. A generic parser for SPDX expressions
will be the better solution.

Test Plan

this is not tested (I do not see how without big effort)

Diff Detail

Repository
R248 Repository management
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr requested review of this revision.Feb 26 2020, 6:17 PM
cordlandwehr created this revision.
cordlandwehr edited the test plan for this revision. (Show Details)Feb 26 2020, 6:18 PM

This looks generally fine to me, although there seem to be some whitespace issues above?

Do not change whitespaces in feature commit

do you anything else or is it ready to be merged?

bcooksley accepted this revision.Mar 16 2020, 9:17 AM

Nothing blocking this no, it just fell off my radar.

This revision is now accepted and ready to land.Mar 16 2020, 9:17 AM
This revision was automatically updated to reflect the committed changes.