Host applications may not always have an active view, and a non-empty list of documents. This would currently crash when clicking the "Search"-button with "Current File" or "Open Files".
Details
Details
Tested with plugin loaded in RKWard, and no documents present. Segfault without patch, no matches, with patch.
Diff Detail
Diff Detail
- Repository
- R40 Kate
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
addons/search/plugin_search.cpp | ||
---|---|---|
1099 | I would format the "if" like this even if it is only one line. if () { foo; } It is easier to set a breakpoint in a debugger... |
Comment Actions
Hm, any hint, why I'm getting this?
remote: FATAL: W refs/heads/master kate tfry DENIED by refs/.* remote: error: hook declined to update refs/heads/master To git.kde.org:kate ! [remote rejected] 3b2561e34af7387b4722e108e7aae648563e5d69 -> master (hook declined) error: failed to push some refs to 'git@git.kde.org:kate'
Comment Actions
I think you pushed to the wrong url, you need to use the one from https://invent.kde.org/kde/kate
git@invent.kde.org:kde/kate.git
Comment Actions
Thanks. That was it.
I was using the default push url from kdesrc-build (which seemed sane to me). Not sure if the push url is configurable, there.