lxr says nobody is loading "gvpart" by name.
Details
Details
- Reviewers
kossebau ngraham - Group Reviewers
Gwenview - Maniphest Tasks
- T12340: Install all parts into plugins/kf5/parts, and add JSON metadata to them
- Commits
- R260:04a776538132: Install the gwenview part into kf5/parts, embed JSON metadata
kparts/bin/partviewer /tmp/myfile.jpg still works, after removing the old gvpart.so
Diff Detail
Diff Detail
- Branch
- kf5_parts
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20594 Build 20612: arc lint + arc unit
Comment Actions
Have not tested. Looks good code-wise, is what I would have done.
+1 (leaving gwenview maintainers the Accept role for now)
| part/CMakeLists.txt | ||
|---|---|---|
| 22 | I know myself how drive-by clean-up is tempting, but as strict reviewer I have to officially say: please separate commit. | |
| part/gvpart.cpp | ||
| 52 | Perhaps set (KF5_MIN_VERSION "5.43.0") can be bumped by one to 5.44.0, so this here could be simply K_PLUGIN_CLASS_WITH_JSON(Gwenview::GVPart, "gvpart.json") | |